linux-kernel - Re: [PATCH -next] nfsd: make nfsd_filecache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200204164051.GA8763@fieldses.org>
Date:   Tue, 4 Feb 2020 11:40:51 -0500
From:   "J. Bruce Fields" <bfields@...ldses.org>
To:     Chen Zhou <chenzhou10@...wei.com>
Cc:     chuck.lever@...cle.com, linux-nfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, yaohongbo@...wei.com
Subject: Re: [PATCH -next] nfsd: make nfsd_filecache_wq variable static

Thanks, applying.--b.

On Mon, Feb 03, 2020 at 09:43:57AM +0800, Chen Zhou wrote:
> Fix sparse warning:
> 
> fs/nfsd/filecache.c:55:25: warning:
> 	symbol 'nfsd_filecache_wq' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Chen Zhou <chenzhou10@...wei.com>
> ---
>  fs/nfsd/filecache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index 23c1fa5..22e77ed 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -52,7 +52,7 @@ struct nfsd_fcache_disposal {
>  	struct rcu_head rcu;
>  };
>  
> -struct workqueue_struct *nfsd_filecache_wq __read_mostly;
> +static struct workqueue_struct *nfsd_filecache_wq __read_mostly;
>  
>  static struct kmem_cache		*nfsd_file_slab;
>  static struct kmem_cache		*nfsd_file_mark_slab;
> -- 
> 2.7.4