linux-kernel - Re: [PATCH 4.19 38/70] platform/x86: GPD pocket fan: Allow somewhat lower/higher temperature limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Feb 2020 20:12:21 +0100
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Jason Anderson <jasona.594@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 38/70] platform/x86: GPD pocket fan: Allow somewhat
 lower/higher temperature limits

Hi!

> From: Hans de Goede <hdegoede@...hat.com>
> 
> [ Upstream commit 1f27dbd8265dbb379926c8f6a4453fe7fe26d7a3 ]
> 
> Allow the user to configure the fan to turn on / speed-up at lower
> thresholds then before (20 degrees Celcius as minimum instead of 40) and
> likewise also allow the user to delay the fan speeding-up till the
> temperature hits 90 degrees Celcius (was 70).

I see it does not break anything, but I don't quite see it as a stable
material.

That said... does lower limit make sense? Spinning fans 10C might be
interesting but not wrong.

Anyway, dev_err() text is now outdated.

Best regards,
								Pavel

>  	for (i = 0; i < ARRAY_SIZE(temp_limits); i++) {
> -		if (temp_limits[i] < 40000 || temp_limits[i] > 70000) {
> +		if (temp_limits[i] < 20000 || temp_limits[i] > 90000) {
>  			dev_err(&pdev->dev, "Invalid temp-limit %d (must be between 40000 and 70000)\n",
>  				temp_limits[i]);
>  			temp_limits[0] = TEMP_LIMIT0_DEFAULT;

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)