[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAD=FV=VaK6faWiAC1CHd081UzWCLEE42dHBq22ZyaSaUu8CXhA@mail.gmail.com>
Date: Tue, 4 Feb 2020 12:49:23 -0800
From: Doug Anderson <dianders@...omium.org>
To: Stephen Boyd <sboyd@...nel.org>
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Rob Herring <robh@...nel.org>,
Jeffrey Hugo <jhugo@...eaurora.org>,
Taniya Das <tdas@...eaurora.org>,
Jeffrey Hugo <jeffrey.l.hugo@...il.com>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
Harigovindan P <harigovi@...eaurora.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>, Matthias Kaehlcke <mka@...omium.org>,
Kalyan Thota <kalyan_t@...eaurora.org>,
Mark Rutland <mark.rutland@....com>,
linux-clk <linux-clk@...r.kernel.org>,
"Kristian H. Kristensen" <hoegsberg@...omium.org>,
Michael Turquette <mturquette@...libre.com>,
LKML <linux-kernel@...r.kernel.org>,
Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v4 11/15] dt-bindings: clock: Cleanup qcom,videocc
bindings for sdm845/sc7180
Hi,
On Tue, Feb 4, 2020 at 9:49 AM Stephen Boyd <sboyd@...nel.org> wrote:
>
> Quoting Douglas Anderson (2020-02-03 10:31:44)
> > This makes the qcom,videocc bindings match the recent changes to the
> > dispcc and gpucc.
> >
> > 1. Switched to using "bi_tcxo" instead of "xo".
> >
> > 2. Adds a description for the XO clock. Not terribly important but
> > nice if it cleanly matches its cousins.
> >
> > 3. Updates the example to use the symbolic name for the RPMH clock and
> > also show that the real devices are currently using 2 address cells
> > / size cells and fixes the spacing on the closing brace.
> >
> > 4. Split into 2 files. In this case they could probably share one
> > file, but let's be consistent.
> >
> > Signed-off-by: Douglas Anderson <dianders@...omium.org>
> > ---
> >
> > Changes in v4:
> > - Added Rob's review tag.
>
> I don't see it. I guess I should add it?
Whoops. I knew I'd mess something like this up. Looks like it got
pushed without his tag but I don't think it's a big deal. For
reference, he added his tag in:
https://lore.kernel.org/r/CAL_Jsq+_2E-bAbP9F6VYkWRp0crEyRGa5peuwP58-PZniVny7w@mail.gmail.com
I did manage to remove the "/bindings" from the ID as he requested, so
at least I didn't mess up the important part...
-Doug
-Doug
Powered by blists - more mailing lists