linux-kernel - Re: [PATCH] KVM: nVMX: Remove stale comment from nested_vmx_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14d6b39b-b907-d1f3-8f15-9b1df0718082@oracle.com>
Date:   Tue, 4 Feb 2020 14:01:00 -0800
From:   Krish Sadhukhan <krish.sadhukhan@...cle.com>
To:     Sean Christopherson <sean.j.christopherson@...el.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: nVMX: Remove stale comment from
 nested_vmx_load_cr3()



On 02/04/2020 12:36 PM, Sean Christopherson wrote:
> On Tue, Feb 04, 2020 at 11:57:39AM -0800, Krish Sadhukhan wrote:
>> On 2/4/20 7:32 AM, Sean Christopherson wrote:
>>> The blurb pertaining to the return value of nested_vmx_load_cr3() no
>>> longer matches reality, remove it entirely as the behavior it is
>>> attempting to document is quite obvious when reading the actual code.
>>>
>>> Signed-off-by: Sean Christopherson <sean.j.christopherson@...el.com>
>>> ---
>>>   arch/x86/kvm/vmx/nested.c | 2 --
>>>   1 file changed, 2 deletions(-)
>>>
>>> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
>>> index 7608924ee8c1..0c9b847f7a25 100644
>>> --- a/arch/x86/kvm/vmx/nested.c
>>> +++ b/arch/x86/kvm/vmx/nested.c
>>> @@ -1076,8 +1076,6 @@ static bool nested_cr3_valid(struct kvm_vcpu *vcpu, unsigned long val)
>>>   /*
>>>    * Load guest's/host's cr3 at nested entry/exit. nested_ept is true if we are
>>>    * emulating VM entry into a guest with EPT enabled.
>>> - * Returns 0 on success, 1 on failure. Invalid state exit qualification code
>>> - * is assigned to entry_failure_code on failure.
>>>    */
>>>   static int nested_vmx_load_cr3(struct kvm_vcpu *vcpu, unsigned long cr3, bool nested_ept,
>>>   			       u32 *entry_failure_code)
>> I think it's worth keeping the last part which is " Exit qualification code
>> is assigned to entry_failure_code on failure." because "Entry Failure" and
>> "Exit Qualification" might sound bit confusing until you actually look at
>> the caller nested_vmx_enter_non_root_mode().
> Hmm, something like this?
>
> /*
>   * Load guest's/host's cr3 at nested entry/exit.  @nested_ept is true if we are
>   * emulating VM-Entry into a guest with EPT enabled.  On failure, the expected
>   * Exit Qualification (for a VM-Entry consistency check VM-Exit) is assigned to
>   * @entry_failure_code.
>   */
It  works.

With that,

Reviewed-by: Krish Sadhukhan <krish.sadhukhan@...cle.com>