linux-kernel - Re: [PATCH v2] dt-bindings: tpm: Convert cr50 binding to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=X5WUVq-g1_2qD7CJrJ1EiYfVOrtiB3hrx98Q+XVyJ0eg@mail.gmail.com>
Date:   Tue, 4 Feb 2020 14:24:17 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Rob Herring <robh@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, Andrey Pronin <apronin@...omium.org>
Subject: Re: [PATCH v2] dt-bindings: tpm: Convert cr50 binding to YAML

Hi,

On Sat, Feb 1, 2020 at 8:39 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> This allows us to validate the dt binding to the implementation. Add the
> interrupt property too, because that's required but nobody noticed when
> the non-YAML binding was introduced.
>
> Cc: Andrey Pronin <apronin@...omium.org>
> Cc: Douglas Anderson <dianders@...omium.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
>
> Changes from v1:
>  * Dropped spi-max-frequency as required
>  * Capped spi-max-frequency at 1MHz
>  * Added interrupt-parent to example to be realistic
>
>  .../bindings/security/tpm/google,cr50.txt     | 19 -------
>  .../bindings/security/tpm/google,cr50.yaml    | 50 +++++++++++++++++++
>  2 files changed, 50 insertions(+), 19 deletions(-)

This seems sane to me.

Reviewed-by: Douglas Anderson <dianders@...omium.org>