linux-kernel - Re: [PATCH] mfd: constify properties in mfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200204224835.GA1128093@kroah.com>
Date:   Tue, 4 Feb 2020 22:48:35 +0000
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Tomas Winkler <tomas.winkler@...el.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: constify properties in mfd_cell

On Tue, Feb 04, 2020 at 10:16:51PM +0200, Tomas Winkler wrote:
> Constify 'struct property_entry *properties' in
> mfd_cell and platform_device. It is always passed
> around as a pointer const struct.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> ---
>  include/linux/mfd/core.h        | 2 +-
>  include/linux/platform_device.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
> index d01d1299e49d..7e5ac3c00891 100644
> --- a/include/linux/mfd/core.h
> +++ b/include/linux/mfd/core.h
> @@ -70,7 +70,7 @@ struct mfd_cell {
>  	size_t			pdata_size;
>  
>  	/* device properties passed to the sub devices drivers */
> -	struct property_entry *properties;
> +	const struct property_entry *properties;
>  
>  	/*
>  	 * Device Tree compatible string
> diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
> index 276a03c24691..8e83c6ff140d 100644
> --- a/include/linux/platform_device.h
> +++ b/include/linux/platform_device.h
> @@ -89,7 +89,7 @@ struct platform_device_info {
>  		size_t size_data;
>  		u64 dma_mask;
>  
> -		struct property_entry *properties;
> +		const struct property_entry *properties;
>  };
>  extern struct platform_device *platform_device_register_full(
>  		const struct platform_device_info *pdevinfo);
> -- 
> 2.21.1
> 

This really is two different patches, can you split and resend?

thanks,

gre gk-h