linux-kernel - Re: [PATCH v2 1/2] kernel.h: Split out min()/max() et al helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c02c86a1-5df3-1b94-78a7-3948bd9e64cb@rasmusvillemoes.dk>
Date:   Wed, 5 Feb 2020 00:23:53 +0100
From:   Rasmus Villemoes <linux@...musvillemoes.dk>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Trond@...ck.fi.intel.com,
        Myklebust@...ck.fi.intel.com, trond.myklebust@...merspace.com,
        Anna Schumaker <anna.schumaker@...app.com>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        Josh Triplett <josh@...htriplett.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v2 1/2] kernel.h: Split out min()/max() et al helpers

On 04/02/2020 18.04, Andy Shevchenko wrote:
> kernel.h is being used as a dump for all kinds of stuff for a long time.
> Here is the attempt to start cleaning it up by splitting out min()/max()
> et al helpers.
> 
> At the same time convert users in header and lib folder to use new header.
> Though for time being include new header back to kernel.h to avoid twisted
> indirected includes for existing users.

This is definitely long overdue, so thanks for taking this on. I think
minmax.h is fine as a header on its own, but for the other one, I think
you should go even further - and perhaps all these should go in a
include/math/ dir (include/linux/ has ~1200 files), so we'd have
math/minmax.h, math/round.h, math/ilog2.h, math/gcd.h etc., each
containing just enough #includes to be self-contained (so if there's a
declaration of something taking a u32, there's no way around having it
include types.h (or wherever that's defined).

Rasmus