linux-kernel - Re: [PATCH v5] Add a "nosymfollow" mount option.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Feb 2020 16:49:48 -0700
From:   Ross Zwisler <zwisler@...omium.org>
To:     Raul Rangel <rrangel@...gle.com>,
        David Howells <dhowells@...hat.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Mattias Nissler <mnissler@...omium.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org,
        Benjamin Gordon <bmgordon@...gle.com>,
        Micah Morton <mortonm@...gle.com>,
        Dmitry Torokhov <dtor@...gle.com>, Jan Kara <jack@...e.cz>,
        Aleksa Sarai <cyphar@...har.com>,
        Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH v5] Add a "nosymfollow" mount option.

On Tue, Feb 4, 2020 at 3:11 PM Ross Zwisler <zwisler@...omium.org> wrote:
> On Tue, Feb 4, 2020 at 2:53 PM Raul Rangel <rrangel@...gle.com> wrote:
> > > --- a/include/uapi/linux/mount.h
> > > +++ b/include/uapi/linux/mount.h
> > > @@ -34,6 +34,7 @@
> > >  #define MS_I_VERSION   (1<<23) /* Update inode I_version field */
> > >  #define MS_STRICTATIME (1<<24) /* Always perform atime updates */
> > >  #define MS_LAZYTIME    (1<<25) /* Update the on-disk [acm]times lazily */
> > > +#define MS_NOSYMFOLLOW (1<<26) /* Do not follow symlinks */
> > Doesn't this conflict with MS_SUBMOUNT below?
> > >
> > >  /* These sb flags are internal to the kernel */
> > >  #define MS_SUBMOUNT     (1<<26)
>
> Yep.  Thanks for the catch, v6 on it's way.

It actually looks like most of the flags which are internal to the
kernel are actually unused (MS_SUBMOUNT, MS_NOREMOTELOCK, MS_NOSEC,
MS_BORN and MS_ACTIVE).  Several are unused completely, and the rest
are just part of the AA_MS_IGNORE_MASK which masks them off in the
apparmor LSM, but I'm pretty sure they couldn't have been set anyway.

I'll just take over (1<<26) for MS_NOSYMFOLLOW, and remove the rest in
a second patch.

If someone thinks these flags are actually used by something and I'm
just missing it, please let me know.