lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Feb 2020 16:41:21 +0800 From: Joseph Qi <joseph.qi@...ux.alibaba.com> To: Alex Shi <alex.shi@...ux.alibaba.com> Cc: Mark Fasheh <mark@...heh.com>, Joel Becker <jlbec@...lplan.org>, Andrew Morton <akpm@...ux-foundation.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Kate Stewart <kstewart@...uxfoundation.org>, ChenGang <cg.chen@...wei.com>, Richard Fontana <rfontana@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, ocfs2-devel@....oracle.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH] OCFS2: remove useless err On 20/1/21 11:37, Alex Shi wrote: > We don't need 'err' in these 2 places, better to remove them. > > Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com> > Cc: Mark Fasheh <mark@...heh.com> > Cc: Joel Becker <jlbec@...lplan.org> > Cc: Joseph Qi <joseph.qi@...ux.alibaba.com> > Cc: Andrew Morton <akpm@...ux-foundation.org> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > Cc: Kate Stewart <kstewart@...uxfoundation.org> > Cc: ChenGang <cg.chen@...wei.com> > Cc: Richard Fontana <rfontana@...hat.com> > Cc: Thomas Gleixner <tglx@...utronix.de> > Cc: ocfs2-devel@....oracle.com > Cc: linux-kernel@...r.kernel.org Reviewed-by: Joseph Qi <joseph.qi@...ux.alibaba.com> > --- > fs/ocfs2/cluster/tcp.c | 3 +-- > fs/ocfs2/dir.c | 4 ++-- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c > index 48a3398f0bf5..9261c1f06a9f 100644 > --- a/fs/ocfs2/cluster/tcp.c > +++ b/fs/ocfs2/cluster/tcp.c > @@ -1948,7 +1948,6 @@ static void o2net_accept_many(struct work_struct *work) > { > struct socket *sock = o2net_listen_sock; > int more; > - int err; > > /* > * It is critical to note that due to interrupt moderation > @@ -1963,7 +1962,7 @@ static void o2net_accept_many(struct work_struct *work) > */ > > for (;;) { > - err = o2net_accept_one(sock, &more); > + o2net_accept_one(sock, &more); > if (!more) > break; > cond_resched(); > diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c > index bdef72c0f099..5761060d2ba8 100644 > --- a/fs/ocfs2/dir.c > +++ b/fs/ocfs2/dir.c > @@ -676,7 +676,7 @@ static struct buffer_head *ocfs2_find_entry_el(const char *name, int namelen, > int ra_ptr = 0; /* Current index into readahead > buffer */ > int num = 0; > - int nblocks, i, err; > + int nblocks, i; > > sb = dir->i_sb; > > @@ -708,7 +708,7 @@ static struct buffer_head *ocfs2_find_entry_el(const char *name, int namelen, > num++; > > bh = NULL; > - err = ocfs2_read_dir_block(dir, b++, &bh, > + ocfs2_read_dir_block(dir, b++, &bh, > OCFS2_BH_READAHEAD); > bh_use[ra_max] = bh; > } >
Powered by blists - more mailing lists