linux-kernel - RE: [PATCH v2 0/3] hw_random: introduce Arm CryptoCell TRNG driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 Feb 2020 08:56:28 +0000
From:   Hadar Gat <Hadar.Gat@....com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Matt Mackall <mpm@...enic.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <Mark.Rutland@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Tomer Maimon <tmaimon77@...il.com>,
        Stefan Wahren <wahrenst@....net>,
        Sumit Garg <sumit.garg@...aro.org>,
        Zaibo Xu <xuzaibo@...wei.com>,
        Weili Qian <qianweili@...wei.com>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@...r.kernel.org>, DTML <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Gilad Ben-Yossef <gilad@...yossef.com>,
        Ofir Drang <Ofir.Drang@....com>, nd <nd@....com>
Subject: RE: [PATCH v2 0/3] hw_random: introduce Arm CryptoCell TRNG driver


> 
> On Sun, Feb 2, 2020 at 2:27 PM Hadar Gat <hadar.gat@....com> wrote:
> >
> > The Arm CryptoCell is a hardware security engine.
> > This patch introduces driver for its TRNG (True Random Number
> > Generator) engine.
> >
> > Changes from previous veriosn: fixed 'make dt_bnding_check' errors.
> >
> > Hadar Gat (3):
> >   dt-bindings: add device tree binding for Arm CryptoCell trng engine
> >   hw_random: cctrng: introduce Arm CryptoCell driver
> >   MAINTAINERS: add HG as cctrng maintainer
> 
> I looked at the patches briefly and everything makes sense to me,
> 
> Acked-by: Arnd Bergmann <arnd@...db.de>
> 
> There are two style issues that you could improve:
> 
> - The header is only included from a single file, so I would just fold
>   its contents into the driver itself.

Although it is included from a single file, I prefer a separated file because it is already contains more than a few definitions and it is most likely that its content will grow in next versions of Arm CryptoCell HW.

> 
> - You have a lot of "#ifdef CONFIG_PM" that are easy to get wrong
>   with various combinations of config symbols. It's often better to
>   leave that all compiled unconditionally and have the logic in
>   UNIVERSAL_DEV_PM_OPS() take care of dropping the unused
>   bits, with a __maybe_unused annotation on functions that cause
>   a warning otherwise.

Thanks Arnd. I'll remove these #ifdef as you suggested.

> 
>        Arnd

Hadar