linux-kernel - Re: memory leak in tcindex_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpWzhdfgHqLQPYwN8dyd37+SMXihM+bf1Cbw3iTV8VE8dw@mail.gmail.com>
Date:   Tue, 4 Feb 2020 16:41:36 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        syzbot+f0bbb2287b8993d4fa74@...kaller.appspotmail.com,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Jakub Kicinski <kuba@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        syzkaller-bugs <syzkaller-bugs@...glegroups.com>
Subject: Re: memory leak in tcindex_set_parms

On Tue, Feb 4, 2020 at 3:40 PM Eric Dumazet <eric.dumazet@...il.com> wrote:
>
> The only thing the repro fires for me on latest net tree is an UBSAN warning about a silly ->shift

Yeah, I thought HEAD commit 322bf2d3 already contains my fix,
I was wrong.


>
> I have not tried it on the old kernel.
>
> [  170.331009] UBSAN: Undefined behaviour in net/sched/cls_tcindex.c:239:29
> [  170.337729] shift exponent 19375 is too large for 32-bit type 'int'

Please send your patch formally, it looks reasonable to me.

Thanks.