linux-kernel - Re: [PATCH v1] Bluetooth: hci_qca: Bug fixes while collecting controller memory dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20C0BA0B-1069-4DCF-A8FA-3B6359621D30@holtmann.org>
Date:   Wed, 5 Feb 2020 13:52:05 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Venkata Lakshmi Narayana Gubba <gubbaven@...eaurora.org>
Cc:     Abhishek Pandit-Subedi <abhishekpandit@...omium.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Matthias Kaehlcke <mka@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Bluez mailing list <linux-bluetooth@...r.kernel.org>,
        robh@...nel.org, hemantg@...eaurora.org,
        linux-arm-msm@...r.kernel.org, bgodavar@...eaurora.org,
        tientzu@...omium.org, seanpaul@...omium.org, rjliao@...eaurora.org,
        Yoni Shavit <yshavit@...gle.com>
Subject: Re: [PATCH v1] Bluetooth: hci_qca: Bug fixes while collecting
 controller memory dump

Hi Venkata,

>> Hi Venkata,
>> Per our earlier review on chromium gerrit:
>> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1992966
>> I'm not too keen on the change from mutex to spinlock because it's
>> made the code more complex.
> [Venkata] :
> 
> We have moved from mutex to spinlock as timer callback function is getting executed under interrupt context and not under process context.

can’t you use a delayed workqueue for this?

Regards

Marcel