linux-kernel - Re: [PATCH] KVM: arm/arm64: Fix up includes for trace.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 05 Feb 2020 15:18:05 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Jeremy Cline <jcline@...hat.com>
Cc:     James Morse <james.morse@....com>,
        Julien Thierry <julien.thierry.kdev@...il.com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: arm/arm64: Fix up includes for trace.h

On 2020-02-05 13:41, Jeremy Cline wrote:
> Fedora kernel builds on armv7hl began failing recently because
> kvm_arm_exception_type and kvm_arm_exception_class were undeclared in
> trace.h. Add the missing include.
> 
> Signed-off-by: Jeremy Cline <jcline@...hat.com>
> ---
> 
> I've not dug very deeply into what exactly changed between commit
> b3a608222336 (the last build that succeeded) and commit 14cd0bd04907,
> but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO
> handling").
> 
> Fedora's build config is available at
> https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config

This config doesn't have KVM enabled.

> 
>  virt/kvm/arm/trace.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h
> index 204d210d01c2..cc94ccc68821 100644
> --- a/virt/kvm/arm/trace.h
> +++ b/virt/kvm/arm/trace.h
> @@ -4,6 +4,7 @@
> 
>  #include <kvm/arm_arch_timer.h>
>  #include <linux/tracepoint.h>
> +#include <asm/kvm_arm.h>
> 
>  #undef TRACE_SYSTEM
>  #define TRACE_SYSTEM kvm

After enabling KVM in the above config (which requires LPAE), I've 
managed to reproduce
the problem.

Fix now queued, thanks.

         M.
-- 
Jazz is not dead. It just smells funny...