lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Feb 2020 01:57:43 +0000 From: linmiaohe <linmiaohe@...wei.com> To: Sean Christopherson <sean.j.christopherson@...el.com> CC: Paolo Bonzini <pbonzini@...hat.com>, Vitaly Kuznetsov <vkuznets@...hat.com>, Wanpeng Li <wanpengli@...cent.com>, Jim Mattson <jmattson@...gle.com>, Joerg Roedel <joro@...tes.org>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] KVM: nVMX: Remove stale comment from nested_vmx_load_cr3() Sean Christopherson <sean.j.christopherson@...el.com> writes: > The blurb pertaining to the return value of nested_vmx_load_cr3() no longer matches reality, remove it entirely as the behavior it is attempting to document is quite obvious when reading the actual code. > > Signed-off-by: Sean Christopherson <sean.j.christopherson@...el.com> > - * Returns 0 on success, 1 on failure. Invalid state exit qualification code > - * is assigned to entry_failure_code on failure. > */ > static int nested_vmx_load_cr3(struct kvm_vcpu *vcpu, unsigned long cr3, bool nested_ept, > u32 *entry_failure_code) It seems the comment is uncorrect as it return -EINVAL on failure. Thanks. Reviewed-by: Miaohe Lin <linmiaohe@...wei.com>
Powered by blists - more mailing lists