lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Feb 2020 19:02:49 +0300
From: Pavel Begunkov <asml.silence@...il.com>
To: Jens Axboe <axboe@...nel.dk>, io-uring@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] io_uring: fix mm use with IORING_OP_{READ,WRITE}
On 05/02/2020 18:54, Jens Axboe wrote:
> On 2/5/20 8:46 AM, Pavel Begunkov wrote:
>> IORING_OP_{READ,WRITE} need mm to access user buffers, hence
>> req->has_user check should go for them as well. Move the corresponding
>> imports past the check.
>
> I'd need to double check, but I think the has_user check should just go.
> The import checks for access anyway, so we'll -EFAULT there if we
> somehow messed up and didn't acquire the right mm.
>
It'd be even better. I have plans to remove it, but I was thinking from a
different angle.
--
Pavel Begunkov
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists