linux-kernel - Re: [PATCH] drm/virtio: ratelimit error logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPaKu7SyqZU=ov4Atbedie6AGC52he0QQJZnGqr545mG-U7vvg@mail.gmail.com>
Date:   Wed, 5 Feb 2020 12:20:12 -0800
From:   Chia-I Wu <olvaffe@...il.com>
To:     Gerd Hoffmann <kraxel@...hat.com>
Cc:     ML dri-devel <dri-devel@...ts.freedesktop.org>,
        Gurchetan Singh <gurchetansingh@...omium.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "open list:VIRTIO GPU DRIVER" 
        <virtualization@...ts.linux-foundation.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/virtio: ratelimit error logging

On Wed, Feb 5, 2020 at 2:26 AM Gerd Hoffmann <kraxel@...hat.com> wrote:
>
> Avoid flooding the log in case we screw up badly.
>
> Signed-off-by: Gerd Hoffmann <kraxel@...hat.com>
Reviewed-by: Chia-I Wu <olvaffe@...il.com>
> ---
>  drivers/gpu/drm/virtio/virtgpu_vq.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
> index 5914e79d3429..83f22933c3bb 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_vq.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
> @@ -212,9 +212,9 @@ void virtio_gpu_dequeue_ctrl_func(struct work_struct *work)
>                         if (resp->type >= cpu_to_le32(VIRTIO_GPU_RESP_ERR_UNSPEC)) {
>                                 struct virtio_gpu_ctrl_hdr *cmd;
>                                 cmd = (struct virtio_gpu_ctrl_hdr *)entry->buf;
> -                               DRM_ERROR("response 0x%x (command 0x%x)\n",
> -                                         le32_to_cpu(resp->type),
> -                                         le32_to_cpu(cmd->type));
> +                               DRM_ERROR_RATELIMITED("response 0x%x (command 0x%x)\n",
> +                                                     le32_to_cpu(resp->type),
> +                                                     le32_to_cpu(cmd->type));
>                         } else
>                                 DRM_DEBUG("response 0x%x\n", le32_to_cpu(resp->type));
>                 }
> --
> 2.18.1
>