linux-kernel - Re: [PATCH][next] tracing/kprobe: Fix uninitialized variable bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6d7de7b-607c-2045-4cf1-f3b2e522c8b0@embeddedor.com>
Date:   Wed, 5 Feb 2020 17:32:08 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Tom Zanussi <zanussi@...nel.org>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Masami Hiramatsu <mhiramat@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] tracing/kprobe: Fix uninitialized variable bug



On 2/5/20 17:24, Tom Zanussi wrote:
> Hi Gustavo,
> 

Hey Tom,

> On Wed, 2020-02-05 at 16:34 -0600, Gustavo A. R. Silva wrote:
>> There is a potential execution path in which variable *ret* is
>> returned
>> without being properly initialized, previously.
>>
>> Fix this by initializing variable *ret* to 0.
>>
> 
> Good catch.  Thanks for fixing this!
> 

Glad to help. :)

> Reviewed-by: Tom Zanussi <zanussi@...nel.org>
> 

Thanks
--
Gustavo

> 
> 
>> Addresses-Coverity-ID: 1491142 ("Uninitialized scalar variable")
>> Fixes: 2a588dd1d5d6 ("tracing: Add kprobe event command generation
>> functions")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>> ---
>>  kernel/trace/trace_kprobe.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/trace/trace_kprobe.c
>> b/kernel/trace/trace_kprobe.c
>> index d8264ebb9581..362cca52f5de 100644
>> --- a/kernel/trace/trace_kprobe.c
>> +++ b/kernel/trace/trace_kprobe.c
>> @@ -1012,7 +1012,7 @@ int __kprobe_event_add_fields(struct
>> dynevent_cmd *cmd, ...)
>>  {
>>  	struct dynevent_arg arg;
>>  	va_list args;
>> -	int ret;
>> +	int ret = 0;
>>  
>>  	if (cmd->type != DYNEVENT_TYPE_KPROBE)
>>  		return -EINVAL;