linux-kernel - Re: [PATCH v2 6/8] ima: Allocate and initialize tfm for each PCR bank

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Feb 2020 07:41:18 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Roberto Sassu <roberto.sassu@...wei.com>
Cc:     kbuild-all@...ts.01.org, zohar@...ux.ibm.com,
        James.Bottomley@...senPartnership.com,
        jarkko.sakkinen@...ux.intel.com, linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, silviu.vlasceanu@...wei.com,
        Roberto Sassu <roberto.sassu@...wei.com>
Subject: Re: [PATCH v2 6/8] ima: Allocate and initialize tfm for each PCR bank

Hi Roberto,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on integrity/next-integrity]
[also build test WARNING on jss-tpmdd/next v5.5 next-20200205]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Roberto-Sassu/ima-support-stronger-algorithms-for-attestation/20200205-233901
base:   https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-integrity
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-154-g1dc00f87-dirty
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)

>> security/integrity/ima/ima_crypto.c:72:12: sparse: sparse: symbol 'ima_init_ima_crypto' was not declared. Should it be static?
   security/integrity/ima/ima_crypto.c:545:36: sparse: sparse: invalid assignment: |=
   security/integrity/ima/ima_crypto.c:545:36: sparse:    left side has type unsigned int
   security/integrity/ima/ima_crypto.c:545:36: sparse:    right side has type restricted fmode_t
   security/integrity/ima/ima_crypto.c:565:28: sparse: sparse: invalid assignment: &=
   security/integrity/ima/ima_crypto.c:565:28: sparse:    left side has type unsigned int
   security/integrity/ima/ima_crypto.c:565:28: sparse:    right side has type restricted fmode_t
   security/integrity/ima/ima_crypto.c:592:52: sparse: sparse: restricted __le32 degrades to integer

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation