linux-kernel - Re: [PATCH] arm: make kexec depend on MMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Feb 2020 10:00:23 +0000
From:   Vladimir Murzin <vladimir.murzin@....com>
To:     Stefan Agner <stefan@...er.ch>, linux@...linux.org.uk
Cc:     Michal Hocko <mhocko@...e.com>, arnd@...db.de,
        linus.walleij@...aro.org, nsekhar@...com,
        linux-kernel@...r.kernel.org, bgolaszewski@...libre.com,
        benjamin.gaignard@...aro.org, mchehab+samsung@...nel.org,
        armlinux@...isordat.com, akpm@...ux-foundation.org,
        linux-arm-kernel@...ts.infradead.org,
        Vincenzo Frascino <Vincenzo.Frascino@....com>
Subject: Re: [PATCH] arm: make kexec depend on MMU

On 2/5/20 10:43 PM, Stefan Agner wrote:
> From: Michal Hocko <mhocko@...e.com>
> 
> arm nommu config with KEXEC enabled doesn't compile
> arch/arm/kernel/setup.c: In function 'reserve_crashkernel':
> arch/arm/kernel/setup.c:1005:25: error: 'SECTION_SIZE' undeclared (first
> use in this function)
>              crash_size, SECTION_SIZE);
> 
> since 61603016e212 ("ARM: kexec: fix crashkernel= handling") which is
> over one year without anybody noticing. I have only noticed beause of
> my testing nommu config which somehow gained CONFIG_KEXEC without
> an intention. This suggests that nobody is actually using KEXEC
> on nommu ARM configs. It is even a question whether kexec works with
> nommu.
> 
> Make KEXEC depend on MMU to make this clear. If somebody wants to enable
> there will be probably more things to take care.
> 
> Signed-off-by: Michal Hocko <mhocko@...e.com>
> Reviewed-by: Stefan Agner <stefan@...er.ch>
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---
>  arch/arm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 96dab76da3b3..59ce8943151f 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1906,6 +1906,7 @@ config KEXEC
>  	bool "Kexec system call (EXPERIMENTAL)"
>  	depends on (!SMP || PM_SLEEP_SMP)
>  	depends on !CPU_V7M
> +	depends on MMU
>  	select KEXEC_CORE
>  	help
>  	  kexec is a system call that implements the ability to shutdown your
> 

Vincenzo sent similar patch [1] some time ago. I prefer his patch since CPU_V7M already imply !MMU.

[1] https://lore.kernel.org/linux-arm-kernel/20200110123125.51092-1-vincenzo.frascino@arm.com/T/

Cheers
Vladimir