linux-kernel - RE: [PATCH v2 4/9] ASoC: tegra: add Tegra210 based I2S driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90ae7badcb3441daa8144233de8f6825@AcuMS.aculab.com>
Date:   Thu, 6 Feb 2020 17:06:47 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Dmitry Osipenko' <digetx@...il.com>,
        Sameer Pujar <spujar@...dia.com>
CC:     "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "jonathanh@...dia.com" <jonathanh@...dia.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "sharadg@...dia.com" <sharadg@...dia.com>,
        "mkumard@...dia.com" <mkumard@...dia.com>,
        "viswanathl@...dia.com" <viswanathl@...dia.com>,
        "rlokhande@...dia.com" <rlokhande@...dia.com>,
        "dramesh@...dia.com" <dramesh@...dia.com>,
        "atalambedu@...dia.com" <atalambedu@...dia.com>
Subject: RE: [PATCH v2 4/9] ASoC: tegra: add Tegra210 based I2S driver

From: f Dmitry Osipenko
> Sent: 06 February 2020 16:59
> 
> 30.01.2020 13:33, Sameer Pujar пишет:
> ...
> > +static const int tegra210_cif_fmt[] = {
> > +	0,
> > +	TEGRA_ACIF_BITS_16,
> > +	TEGRA_ACIF_BITS_32,
> > +};
> > +
> > +static const int tegra210_i2s_bit_fmt[] = {
> > +	0,
> > +	I2S_BITS_16,
> > +	I2S_BITS_32,
> > +};
> > +
> > +static const int tegra210_i2s_sample_size[] = {
> > +	0,
> > +	16,
> > +	32,
> > +};
> 
> static const *unsigned* int?

Or get rid of the table lookups completely.
Assuming the index is never zero then the value
can be calculated as (const_a + const_b * index).

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)