linux-kernel - Re: [PATCH v12 1/2] fs: New zonefs file system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <02780281-ddb3-7a2f-b5af-cc317d4adf45@web.de>
Date:   Thu, 6 Feb 2020 20:56:05 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Damien Le Moal <Damien.LeMoal@....com>,
        linux-fsdevel@...r.kernel.org, linux-xfs@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        Dave Chinner <david@...morbit.com>,
        Hannes Reinecke <hare@...e.de>,
        Johannes Thumshirn <jth@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Naohiro Aota <Naohiro.Aota@....com>
Subject: Re: [PATCH v12 1/2] fs: New zonefs file system

> zonefs is a very simple file system …

How do you think about to be consistent with the capitalisation
at the beginning of such sentences?
https://lore.kernel.org/linux-fsdevel/20200206052631.111586-1-damien.lemoal@wdc.com/


…
> +++ b/fs/zonefs/super.c
…
> +static int zonefs_create_zgroup(struct zonefs_zone_data *zd,
> +				enum zonefs_ztype type)
> +{
…
> +	if (type == ZONEFS_ZTYPE_CNV)
> +		zgroup_name = "cnv";
> +	else
> +		zgroup_name = "seq";

I find the following code variant more succinct.

+	zgroup_name = (type == ZONEFS_ZTYPE_CNV) ? "cnv" : "seq";


Regards,
Markus