linux-kernel - Re: [Question] some questions about vmx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <736f8beabe2046fdab0631f28f9d2b1f@huawei.com>
Date:   Fri, 7 Feb 2020 07:10:48 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>
CC:     "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "sean.j.christopherson@...el.com" <sean.j.christopherson@...el.com>,
        "wanpengli@...cent.com" <wanpengli@...cent.com>,
        "jmattson@...gle.com" <jmattson@...gle.com>,
        "joro@...tes.org" <joro@...tes.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "hpa@...or.com" <hpa@...or.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [Question] some questions about vmx

Hi:
Vitaly Kuznetsov <vkuznets@...hat.com> writes:
>linmiaohe <linmiaohe@...wei.com> writes:
>
>> About nWMX.
>> When nested_vmx_handle_enlightened_vmptrld() return 0, it do not 
>> inject any exception or set rflags to Indicate VMLAUNCH instruction 
>> failed and skip this instruction. This would cause nested_vmx_run() 
>
>Yes, it seems it can. 
>
>nested_vmx_handle_enlightened_vmptrld() has two possible places where it can fail:
>
>kvm_vcpu_map() -- meaning that the guest passed some invalid GPA.
>revision id check -- meaning that the supplied eVMCS is unsupported/garbage.
>
>I think the right behavior would be to nested_vmx_failInvalid() in both these cases. We can also check what genuing Hyper-V does.
>

Many thanks for your reply. I think this would be a problem too. And would you like to fix this potential problem? I have no idea
how to fix this correctly... Thanks again.