linux-kernel - Re: [PATCH net] net: dsa: b53: Always use dev->vlan_enabled in b53_configure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 07 Feb 2020 11:27:53 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, andrew@...n.ch, vivien.didelot@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: b53: Always use dev->vlan_enabled in
 b53_configure_vlan()

From: Florian Fainelli <f.fainelli@...il.com>
Date: Thu,  6 Feb 2020 11:07:45 -0800

> b53_configure_vlan() is called by the bcm_sf2 driver upon setup and
> indirectly through resume as well. During the initial setup, we are
> guaranteed that dev->vlan_enabled is false, so there is no change in
> behavior, however during suspend, we may have enabled VLANs before, so we
> do want to restore that setting.
> 
> Fixes: dad8d7c6452b ("net: dsa: b53: Properly account for VLAN filtering")
> Fixes: 967dd82ffc52 ("net: dsa: b53: Add support for Broadcom RoboSwitch")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied and queued up for -stable.