lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Feb 2020 16:53:45 +0530 From: Sameer Pujar <spujar@...dia.com> To: David Laight <David.Laight@...LAB.COM>, 'Dmitry Osipenko' <digetx@...il.com> CC: <spujar@...dia.com>, "perex@...ex.cz" <perex@...ex.cz>, "tiwai@...e.com" <tiwai@...e.com>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "broonie@...nel.org" <broonie@...nel.org>, "lgirdwood@...il.com" <lgirdwood@...il.com>, "thierry.reding@...il.com" <thierry.reding@...il.com>, "jonathanh@...dia.com" <jonathanh@...dia.com>, "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "sharadg@...dia.com" <sharadg@...dia.com>, "mkumard@...dia.com" <mkumard@...dia.com>, "viswanathl@...dia.com" <viswanathl@...dia.com>, "rlokhande@...dia.com" <rlokhande@...dia.com>, "dramesh@...dia.com" <dramesh@...dia.com>, "atalambedu@...dia.com" <atalambedu@...dia.com> Subject: Re: [PATCH v2 4/9] ASoC: tegra: add Tegra210 based I2S driver On 2/6/2020 10:36 PM, David Laight wrote: > External email: Use caution opening links or attachments > > > From: f Dmitry Osipenko >> Sent: 06 February 2020 16:59 >> >> 30.01.2020 13:33, Sameer Pujar пишет: >> ... >>> +static const int tegra210_cif_fmt[] = { >>> + 0, >>> + TEGRA_ACIF_BITS_16, >>> + TEGRA_ACIF_BITS_32, >>> +}; >>> + >>> +static const int tegra210_i2s_bit_fmt[] = { >>> + 0, >>> + I2S_BITS_16, >>> + I2S_BITS_32, >>> +}; >>> + >>> +static const int tegra210_i2s_sample_size[] = { >>> + 0, >>> + 16, >>> + 32, >>> +}; >> static const *unsigned* int? > Or get rid of the table lookups completely. > Assuming the index is never zero then the value > can be calculated as (const_a + const_b * index). All above tables are mapped to tegra210_i2s_format_text[]. Additions/removal of entries will require changes in equation. It is better keep the mapping as it is. > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales)
Powered by blists - more mailing lists