linux-kernel - Re: [PATCH net] net: ethernet: ave: Add capability of rgmii-id mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200207205901.BE9A.4A936039@socionext.com>
Date:   Fri, 07 Feb 2020 20:59:01 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     David Miller <davem@...emloft.net>
Cc:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <masami.hiramatsu@...aro.org>, <jaswinder.singh@...aro.org>
Subject: Re: [PATCH net] net: ethernet: ave: Add capability of rgmii-id mode

Hi David, 
Thank you for your comment.

On Fri, 7 Feb 2020 11:16:48 +0100 <davem@...emloft.net> wrote:

> From: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
> Date: Thu,  6 Feb 2020 10:59:36 +0900
> 
> > This allows you to specify the type of rgmii-id that will enable phy
> > internal delay in ethernet phy-mode.
> > 
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
> 
> I do not understand this change at all.
> 
> At a minimum you must explain things more clearly and completely in your
> commit message.
> 
> Are you just adding all of the RGMII cases to the code that only currently
> mentions PHY_INTERFACE_MODE_RGMII?  If so, why did you only do this for
> some but not all of the get_pinmode() methods in this driver?

Yes, this is intended to add all of RGMII cases to the code.
I add the cases to all of get_pinmode() except LD11, because LD11 doesn't
support RGMII due to the constraint of the hardware.

When RGMII phy mode is specified in the devicetree for LD11, the driver
will abort with the message "invalid phy-mode setting".

If it is clear, I'll add this to the next commit message.

Thank you,

---
Best Regards,
Kunihiko Hayashi