linux-kernel - Re: [PATCH 14/28] ata: move ata_dev_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc3b7968-368f-554f-d12f-e53e4858bc98@samsung.com>
Date:   Fri, 7 Feb 2020 15:23:58 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Michael Schmitz <schmitzmic@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/28] ata: move ata_dev_config_ncq*() to
 libata-core-sata.c


On 1/29/20 6:29 PM, Christoph Hellwig wrote:
> On Tue, Jan 28, 2020 at 02:33:29PM +0100, Bartlomiej Zolnierkiewicz wrote:
>> * move ata_log_supported() to libata.h and make it inline
>>
>> * move ata_dev_config_ncq*() to libata-core-sata.c
>>
>> * add static inline version of ata_dev_config_ncq() for
>>   CONFIG_SATA_HOST=n case
> 
> Wouldn't it be easier to throw in an IS_ENABLED() into the
> ATA_FLAG_FPDMA_AUX before calling ata_dev_config_ncq_* and let the
> compiler optimize out the functions?

I've reworked the code to use this approach in v2 of the patchset.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics