linux-kernel - Re: [PATCH] kcsan: Expose core configuration parameters as module params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200207194021.GO2935@paulmck-ThinkPad-P72>
Date:   Fri, 7 Feb 2020 11:40:21 -0800
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Marco Elver <elver@...gle.com>
Cc:     andreyknvl@...gle.com, glider@...gle.com, dvyukov@...gle.com,
        kasan-dev@...glegroups.com, linux-kernel@...r.kernel.org,
        Qian Cai <cai@....pw>, mingo@...nel.org, will@...nel.org,
        torvalds@...ux-foundation.org
Subject: Re: [PATCH] kcsan: Expose core configuration parameters as module
 params

On Fri, Feb 07, 2020 at 07:59:10PM +0100, Marco Elver wrote:
> This adds early_boot, udelay_{task,interrupt}, and skip_watch as module
> params. The latter parameters are useful to modify at runtime to tune
> KCSAN's performance on new systems. This will also permit auto-tuning
> these parameters to maximize overall system performance and KCSAN's race
> detection ability.
> 
> None of the parameters are used in the fast-path and referring to them
> via static variables instead of CONFIG constants will not affect
> performance.
> 
> Signed-off-by: Marco Elver <elver@...gle.com>
> Cc: Qian Cai <cai@....pw>

Thank you both!

I have pulled this in, and have also rebased the KCSAN commits into a
separate branch named kcsan in -rcu.  This allows people to use current
KCSAN without exposing themselves to random RCU changes.

f60f0f543333 ("kcsan: Expose core configuration parameters as module params")

git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git

I just now kicked off a short sanity test with rcutorture, and will of
course do more testing over time.

							Thanx, Paul

> ---
>  kernel/kcsan/core.c | 24 +++++++++++++++++++-----
>  1 file changed, 19 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/kcsan/core.c b/kernel/kcsan/core.c
> index 87ef01e40199d..498b1eb3c1cda 100644
> --- a/kernel/kcsan/core.c
> +++ b/kernel/kcsan/core.c
> @@ -6,6 +6,7 @@
>  #include <linux/export.h>
>  #include <linux/init.h>
>  #include <linux/kernel.h>
> +#include <linux/moduleparam.h>
>  #include <linux/percpu.h>
>  #include <linux/preempt.h>
>  #include <linux/random.h>
> @@ -16,6 +17,20 @@
>  #include "encoding.h"
>  #include "kcsan.h"
>  
> +static bool kcsan_early_enable = IS_ENABLED(CONFIG_KCSAN_EARLY_ENABLE);
> +static unsigned int kcsan_udelay_task = CONFIG_KCSAN_UDELAY_TASK;
> +static unsigned int kcsan_udelay_interrupt = CONFIG_KCSAN_UDELAY_INTERRUPT;
> +static long kcsan_skip_watch = CONFIG_KCSAN_SKIP_WATCH;
> +
> +#ifdef MODULE_PARAM_PREFIX
> +#undef MODULE_PARAM_PREFIX
> +#endif
> +#define MODULE_PARAM_PREFIX "kcsan."
> +module_param_named(early_enable, kcsan_early_enable, bool, 0);
> +module_param_named(udelay_task, kcsan_udelay_task, uint, 0644);
> +module_param_named(udelay_interrupt, kcsan_udelay_interrupt, uint, 0644);
> +module_param_named(skip_watch, kcsan_skip_watch, long, 0644);
> +
>  bool kcsan_enabled;
>  
>  /* Per-CPU kcsan_ctx for interrupts */
> @@ -239,9 +254,9 @@ should_watch(const volatile void *ptr, size_t size, int type)
>  
>  static inline void reset_kcsan_skip(void)
>  {
> -	long skip_count = CONFIG_KCSAN_SKIP_WATCH -
> +	long skip_count = kcsan_skip_watch -
>  			  (IS_ENABLED(CONFIG_KCSAN_SKIP_WATCH_RANDOMIZE) ?
> -				   prandom_u32_max(CONFIG_KCSAN_SKIP_WATCH) :
> +				   prandom_u32_max(kcsan_skip_watch) :
>  				   0);
>  	this_cpu_write(kcsan_skip, skip_count);
>  }
> @@ -253,8 +268,7 @@ static __always_inline bool kcsan_is_enabled(void)
>  
>  static inline unsigned int get_delay(void)
>  {
> -	unsigned int delay = in_task() ? CONFIG_KCSAN_UDELAY_TASK :
> -					 CONFIG_KCSAN_UDELAY_INTERRUPT;
> +	unsigned int delay = in_task() ? kcsan_udelay_task : kcsan_udelay_interrupt;
>  	return delay - (IS_ENABLED(CONFIG_KCSAN_DELAY_RANDOMIZE) ?
>  				prandom_u32_max(delay) :
>  				0);
> @@ -527,7 +541,7 @@ void __init kcsan_init(void)
>  	 * We are in the init task, and no other tasks should be running;
>  	 * WRITE_ONCE without memory barrier is sufficient.
>  	 */
> -	if (IS_ENABLED(CONFIG_KCSAN_EARLY_ENABLE))
> +	if (kcsan_early_enable)
>  		WRITE_ONCE(kcsan_enabled, true);
>  }
>  
> -- 
> 2.25.0.341.g760bfbb309-goog
>