linux-kernel - Re: [PATCH v2] PCI/P2PDMA: Add the remaining Intel Sky Lake-E root ports to the whitelist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a70eb8eb-c584-0a53-07a9-9078b68712e4@deltatee.com>
Date:   Fri, 7 Feb 2020 15:20:35 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Andrew Maier <andrew.maier@...eticom.com>, bhelgaas@...gle.com,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Armen Baloyan <abaloyan@...aio.com>
Subject: Re: [PATCH v2] PCI/P2PDMA: Add the remaining Intel Sky Lake-E root
 ports to the whitelist

+cc Armen

On 2020-02-07 3:12 p.m., Andrew Maier wrote:
> Add the three remaining Intel Sky Lake-E host root ports to the
> whitelist of p2pdma.
> 
> P2P has been tested and is working on this system.
> 
> Signed-off-by: Andrew Maier <andrew.maier@...eticom.com>
> ---
> Resending this as I rebased it onto the latest patches.

Right, this is the same machine Armen already sent, so I've CC'd him.

Looks like we're just adding the extra possible root ports from the PCI
IDs database:

2031	Sky Lake-E PCI Express Root Port B	
2032	Sky Lake-E PCI Express Root Port C	
2033	Sky Lake-E PCI Express Root Port D

Makes sense to me, thanks,

Reviewed-by: Logan Gunthorpe <logang@...tatee.com>

>  drivers/pci/p2pdma.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
> index 9a8a38384121..b73b10bce0df 100644
> --- a/drivers/pci/p2pdma.c
> +++ b/drivers/pci/p2pdma.c
> @@ -291,6 +291,9 @@ static const struct pci_p2pdma_whitelist_entry {
>  	{PCI_VENDOR_ID_INTEL,	0x2f01, REQ_SAME_HOST_BRIDGE},
>  	/* Intel SkyLake-E */
>  	{PCI_VENDOR_ID_INTEL,	0x2030, 0},
> +	{PCI_VENDOR_ID_INTEL,	0x2031, 0},
> +	{PCI_VENDOR_ID_INTEL,	0x2032, 0},
> +	{PCI_VENDOR_ID_INTEL,	0x2033, 0},
>  	{PCI_VENDOR_ID_INTEL,	0x2020, 0},
>  	{}
>  };
>