linux-kernel - Re: [PATCH v2 2/2] dt-binding: spi: add bindings for spi-ar934x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 8 Feb 2020 17:36:57 +0800
From:   Chuanhong Guo <gch981213@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Rob Herring <robh@...nel.org>, linux-spi@...r.kernel.org,
        Mark Brown <broonie@...nel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] dt-binding: spi: add bindings for spi-ar934x

On Sat, Feb 8, 2020 at 7:54 AM Florian Fainelli <f.fainelli@...il.com> wrote:
> On 2/6/20 9:55 PM, Chuanhong Guo wrote:
> > It's caused by "clocks = <&pll ATH79_CLK_AHB>" where ATH79_CLK_AHB
> > isn't defined without a include of dt-bindings/clock/ath79-clk.h
> > I'll replace this with a bogus "clocks = <&spi_clock>" instead in v3.
>
> You can include ath79-clk.h in your example, see for instance
> Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml

Oh. But I've already sent v3 out yesterday :(

I think this is just cosmetic changes and doesn't make much difference
so I'd like to keep v3 as-is now and if there are other comments for
me to send a v4 I'll change this one as well.

Regards,
Chuanhong Guo