linux-kernel - Re: [PATCH v5 11/18] usb: dwc3: Add support for a role-switch notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9e653a9a-2fc4-645c-ac33-d9826a7ecbd9@linaro.org>
Date:   Sat, 8 Feb 2020 00:28:33 +0000
From:   Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To:     Jack Pham <jackp@...eaurora.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
        gregkh@...uxfoundation.org, balbi@...nel.org,
        bjorn.andersson@...aro.org, robh@...nel.org,
        linux-kernel@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH v5 11/18] usb: dwc3: Add support for a role-switch
 notifier

On 08/02/2020 00:15, Jack Pham wrote:
> Hi Bryan,
> 
> On Fri, Feb 07, 2020 at 08:16:47PM +0000, Bryan O'Donoghue wrote:
>> Role-switching is a 1:1 mapping between a producer and a consumer. For DWC3
>> we have some vendor specific wrappers, notably the qcom wrapper that want
>> to toggle some PHY related bits on a USB role switch.
>>
>> This patch adds a role-switch notifier to the dwc3 drd code. When the USB
>> role-switch set() routine runs, the notifier will fire passing the notified
>> mode to the consumer, thus allowing vendor specific fix-ups to toggle from
>> the role-switching events.
> 
> Neat! This could work. But let's see if Felipe likes this approach.
> 
> If you need, here's a
> 
> Reviewed-by: Jack Pham <jackp@...eaurora.org>

Appreciated