[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CANXhq0qL6oSsHOr+eFOYhBSAXPP5k=k0mwxEdHMGfUV9CSBHkA@mail.gmail.com>
Date: Sat, 8 Feb 2020 16:45:31 +0800
From: Zong Li <zong.li@...ive.com>
To: Joe Perches <joe@...ches.com>
Cc: Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
linux-riscv <linux-riscv@...ts.infradead.org>,
"linux-kernel@...r.kernel.org List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] riscv: adjust the indent
On Fri, Feb 7, 2020 at 6:59 PM Joe Perches <joe@...ches.com> wrote:
>
> On Fri, 2020-02-07 at 17:52 +0800, Zong Li wrote:
> > Adjust the indent to match Linux coding style.
>
> trivia:
>
> > diff --git a/arch/riscv/mm/kasan_init.c b/arch/riscv/mm/kasan_init.c
> []
> > @@ -86,7 +89,8 @@ void __init kasan_init(void)
> > unsigned long i;
> >
> > kasan_populate_early_shadow((void *)KASAN_SHADOW_START,
> > - (void *)kasan_mem_to_shadow((void *)VMALLOC_END));
> > + (void *)kasan_mem_to_shadow((void *)
> > + VMALLOC_END));
>
> could also remove an unnecessary (void *) as kasan_mem_to_shadow
> returns a void *
>
> kasan_populate_early_shadow((void *)KASAN_SHADOW_START,
> kasan_mem_to_shadow((void *)VMALLOC_END));
>
OK, I'll remove it in next version. Thanks.
Powered by blists - more mailing lists