linux-kernel - Re: [PATCH v2 5/6] interconnect: qcom: sdm845: Split qnodes into their respective NoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9f1675f15fdf6b627f0ce12b1a6cea9a@codeaurora.org>
Date:   Sun, 09 Feb 2020 23:34:29 +0530
From:   Sibi Sankar <sibis@...eaurora.org>
To:     Evan Green <evgreen@...gle.com>
Cc:     David Dai <daidavid1@...eaurora.org>,
        Georgi Djakov <georgi.djakov@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, sboyd@...nel.org,
        Lina Iyer <ilina@...eaurora.org>,
        Sean Sweeney <seansw@....qualcomm.com>,
        Alex Elder <elder@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        linux-pm@...r.kernel.org, linux-arm-msm-owner@...r.kernel.org
Subject: Re: [PATCH v2 5/6] interconnect: qcom: sdm845: Split qnodes into
 their respective NoCs

On 2020-02-04 23:51, Evan Green wrote:
> On Thu, Jan 9, 2020 at 8:33 PM David Dai <daidavid1@...eaurora.org> 
> wrote:
>> 
>> In order to better represent the hardware and its different 
>> Network-On-Chip
>> devices, split the sdm845 provider driver into NoC specific providers.
>> Remove duplicate functionality already provided by the icc rpmh and
>> bcm voter drivers to calculate and commit bandwidth requests to 
>> hardware.
>> 
>> Signed-off-by: David Dai <daidavid1@...eaurora.org>
>> ---
>>  drivers/interconnect/qcom/sdm845.c             | 1132 
>> ++++++++++--------------
>>  include/dt-bindings/interconnect/qcom,sdm845.h |  263 +++---
>>  2 files changed, 609 insertions(+), 786 deletions(-)
>> 
>> diff --git a/drivers/interconnect/qcom/sdm845.c 
>> b/drivers/interconnect/qcom/sdm845.c
>> index f078cf0..8145612 100644
>> --- a/drivers/interconnect/qcom/sdm845.c
>> +++ b/drivers/interconnect/qcom/sdm845.c
>> @@ -5,283 +5,285 @@
>>   */
>> 
>>  #include <asm/div64.h>
> 
> You don't need this header anymore, right?
> 
>> -#include <dt-bindings/interconnect/qcom,sdm845.h>
>>  #include <linux/device.h>
>>  #include <linux/interconnect.h>
>>  #include <linux/interconnect-provider.h>
>>  #include <linux/io.h>

^^ can also be dropped

>>  #include <linux/module.h>
>>  #include <linux/of_device.h>
>> -#include <linux/of_platform.h>

^^ can also be dropped

>> -#include <linux/platform_device.h>
>>  #include <linux/sort.h>
> 
> ..or this one.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.