linux-kernel - [PATCH 06/11] sched/deadline: Add missing annotation for dl_task_offline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4cebf47c30ce24ee1972f4b6330376d8f32802b9.1581282103.git.jbi.octave@gmail.com>
Date:   Sun,  9 Feb 2020 22:39:33 +0000
From:   Jules Irenge <jbi.octave@...il.com>
To:     boqun.feng@...il.com
Cc:     juri.lelli@...hat.com, peterz@...radead.org, mingo@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        linux-kernel@...r.kernel.org, Jules Irenge <jbi.octave@...il.com>
Subject: [PATCH 06/11] sched/deadline: Add missing annotation for dl_task_offline_migration()

Sparse reports warning at dl_task_offline_migration()

warning: context imbalance in dl_task_offline_migration()
	 - unexpected unlock

The root cause is the missing annotation for dl_task_offline_migration()

Add the missing __releases(rq->lock) annotation.

Signed-off-by: Jules Irenge <jbi.octave@...il.com>
---
 kernel/sched/deadline.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 43323f875cb9..68ea3a4933db 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -527,6 +527,7 @@ static inline void deadline_queue_pull_task(struct rq *rq)
 static struct rq *find_lock_later_rq(struct task_struct *task, struct rq *rq);
 
 static struct rq *dl_task_offline_migration(struct rq *rq, struct task_struct *p)
+	__releases(rq->lock)
 {
 	struct rq *later_rq = NULL;
 	struct dl_bw *dl_b;
-- 
2.24.1