linux-kernel - Re: [PATCH 2/3] Input: snvs_pwrkey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Feb 2020 06:33:30 +0000
From:   Horia Geanta <horia.geanta@....com>
To:     Robin Gong <yibin.gong@....com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:     André Draszik <git@...red.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Anson Huang <anson.huang@....com>,
        Aymen Sghaier <aymen.sghaier@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH 2/3] Input: snvs_pwrkey - enable snvs clock as needed

On 2/10/2020 4:03 AM, Robin Gong wrote:
> On 2020/02/10 Dmitry Torokhov <dmitry.torokhov@...il.com> wrote: 
>> On Fri, Feb 07, 2020 at 08:10:22AM +0000, Horia Geanta wrote:
>>> On 1/30/2020 10:45 PM, André Draszik wrote:
>>>> @@ -140,6 +148,25 @@ static int imx_snvs_pwrkey_probe(struct
>> platform_device *pdev)
>>>>  	if (pdata->irq < 0)
>>>>  		return -EINVAL;
>>>>
>>>> +	pdata->clk = devm_clk_get(&pdev->dev, "snvs-pwrkey");
>>>> +	if (IS_ERR(pdata->clk)) {
>>>> +		pdata->clk = NULL;
>>> Using devm_clk_get_optional() would simplify error handling.
>>
>> It sounds to me that this clock is not at all optional and the driver currently
>> "works" only by accident and therefore optional is not suitable here.
> Yes, then we need to add all snvs clk in dts for on legacy i.MX chips in this patchset
> to avoid any potential function broken.
In that case the DT binding should be updated too,
to make the clock mandatory.
But before doing this all i.MX SoCs should be checked.

Thanks,
Horia