linux-kernel - Re: [PATCH 2/4] perf tools: Mark ksymbol dsos with kernel type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200210152537.GA28110@krava>
Date:   Mon, 10 Feb 2020 16:25:37 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>,
        Ravi Bangoria <ravi.bangoria@...ux.ibm.com>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Michael Petlan <mpetlan@...hat.com>
Subject: Re: [PATCH 2/4] perf tools: Mark ksymbol dsos with kernel type

On Mon, Feb 10, 2020 at 12:17:59PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Feb 10, 2020 at 03:32:16PM +0100, Jiri Olsa escreveu:
> > We add ksymbol map into machine->kmaps, so it needs to be
> > created as 'struct kmap', which is dependent on its dso
> > having kernel type.
> > 
> > Reported-by: Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
> > Tested-by: Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
> > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> > ---
> >  tools/perf/util/machine.c | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> > index e3e5490f6de5..0a43dc83d7b2 100644
> > --- a/tools/perf/util/machine.c
> > +++ b/tools/perf/util/machine.c
> > @@ -727,8 +727,14 @@ static int machine__process_ksymbol_register(struct machine *machine,
> >  	struct map *map = maps__find(&machine->kmaps, event->ksymbol.addr);
> >  
> >  	if (!map) {
> > -		map = dso__new_map(event->ksymbol.name);
> > -		if (!map)
> > +		struct dso *dso = dso__new(event->ksymbol.name);
> > +
> > +		if (dso) {
> > +			dso->kernel = DSO_TYPE_KERNEL;
> > +			map = map__new2(0, dso);
> > +		}
> > +
> > +		if (!dso || !map)
> 
> We leak dso if map creation fails?

yep :-\ will post v2

thanks,
jirka

> 
> 
> - Arnaldo
> 
> >  			return -ENOMEM;
> >  
> >  		map->start = event->ksymbol.addr;
> > -- 
> > 2.24.1
> > 
> 
> -- 
> 
> - Arnaldo
>