linux-kernel - Re: [PATCH] phy: core: Add consumer device link support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd72269-16ae-b24a-7144-44d22d668dc6@ti.com>
Date:   Mon, 10 Feb 2020 13:38:16 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     youling 257 <youling257@...il.com>
CC:     <alexandre.torgue@...com>, <yoshihiro.shimoda.uh@...esas.com>,
        <gregkh@...uxfoundation.org>, <linux-kernel@...r.kernel.org>,
        <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] phy: core: Add consumer device link support

Hi Alexandre,

On 07/02/20 12:27 PM, youling 257 wrote:
> test this diff, dwc3 work for my device, thanks.
> 
> 2020-02-07 13:16 GMT+08:00, Kishon Vijay Abraham I <kishon@...com>:
>> Hi,
>>
>> On 06/02/20 7:09 PM, youling257 wrote:
>>> This patch cause "dwc3 dwc3.3.auto: failed to create device link to
>>> dwc3.3.auto.ulpi" problem.
>>> https://bugzilla.kernel.org/show_bug.cgi?id=206435
>>
>> I'm suspecting there is some sort of reverse dependency with dwc3 ULPI.
>> Can you try the following diff?
>>
>> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
>> index 2eb28cc2d2dc..397311dcb116 100644
>> --- a/drivers/phy/phy-core.c
>> +++ b/drivers/phy/phy-core.c
>> @@ -687,7 +687,7 @@ struct phy *phy_get(struct device *dev, const char
>> *string)
>>
>>         get_device(&phy->dev);
>>
>> -       link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
>> +       link = device_link_add(dev, &phy->dev, DL_FLAG_SYNC_STATE_ONLY);
>>         if (!link) {
>>                 dev_err(dev, "failed to create device link to %s\n",
>>                         dev_name(phy->dev.parent));
>> @@ -802,7 +802,7 @@ struct phy *devm_of_phy_get(struct device *dev,
>> struct device_node *np,
>>                 return phy;
>>         }
>>
>> -       link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
>> +       link = device_link_add(dev, &phy->dev, DL_FLAG_SYNC_STATE_ONLY);
>>         if (!link) {
>>                 dev_err(dev, "failed to create device link to %s\n",
>>                         dev_name(phy->dev.parent));
>> @@ -851,7 +851,7 @@ struct phy *devm_of_phy_get_by_index(struct device
>> *dev, struct device_node *np,
>>         *ptr = phy;
>>         devres_add(dev, ptr);
>>
>> -       link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
>> +       link = device_link_add(dev, &phy->dev, DL_FLAG_SYNC_STATE_ONLY);
>>         if (!link) {
>>                 dev_err(dev, "failed to create device link to %s\n",
>>                         dev_name(phy->dev.parent));Parent

Can you check if this doesn't affect the suspend/resume ordering?

Thanks
Kishon