linux-kernel - Re: [PATCH] drivers base/arch_topology: Remove 'struct sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200210160252.GA702121@kroah.com>
Date:   Mon, 10 Feb 2020 08:02:52 -0800
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Dietmar Eggemann <dietmar.eggemann@....com>
Cc:     Sudeep Holla <sudeep.holla@....com>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Juri Lelli <juri.lelli@...hat.com>
Subject: Re: [PATCH] drivers base/arch_topology: Remove 'struct sched_domain'
 forward declaration

On Mon, Feb 10, 2020 at 04:24:20PM +0100, Dietmar Eggemann wrote:
> The sched domain pointer argument from topology_get_freq_scale() and
> topology_get_cpu_scale() got removed by commit 7673c8a4c75d
> ("sched/cpufreq: Remove arch_scale_freq_capacity()'s 'sd' parameter")
> and commit 8ec59c0f5f49 ("sched/topology: Remove unused 'sd' parameter
> from arch_scale_cpu_capacity()").
> 
> So the 'struct sched_domain' forward declaration is no longer needed.
> Remove it.
> 
> W/o the sched domain pointer argument the storage class and inline
> definition as well as the return type, function name and parameter list
> fit all into one line.
> 
> Signed-off-by: Dietmar Eggemann <dietmar.eggemann@....com>
> Reviewed-by: Sudeep Holla <sudeep.holla@....com>
> ---
>  include/linux/arch_topology.h | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h
> index 3015ecbb90b1..c507e9ddd909 100644
> --- a/include/linux/arch_topology.h
> +++ b/include/linux/arch_topology.h
> @@ -16,9 +16,7 @@ bool topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu);
>  
>  DECLARE_PER_CPU(unsigned long, cpu_scale);
>  
> -struct sched_domain;
> -static inline
> -unsigned long topology_get_cpu_scale(int cpu)
> +static inline unsigned long topology_get_cpu_scale(int cpu)
>  {
>  	return per_cpu(cpu_scale, cpu);
>  }
> @@ -27,8 +25,7 @@ void topology_set_cpu_scale(unsigned int cpu, unsigned long capacity);
>  
>  DECLARE_PER_CPU(unsigned long, freq_scale);
>  
> -static inline
> -unsigned long topology_get_freq_scale(int cpu)
> +static inline unsigned long topology_get_freq_scale(int cpu)

You are doing two different things in this patch :(

Reformatting the function names are fine, but that has nothing to do
with dropping the "struct sched_domain;" line.  Please split into 2
different patches.

thanks,

greg k-h