[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <af481087-388d-fe65-6a42-af5cccb9a46b@intel.com>
Date: Mon, 10 Feb 2020 09:35:35 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: YueHaibing <yuehaibing@...wei.com>, vkoul@...nel.org,
dan.j.williams@...el.com
Cc: dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] dmaengine: idxd: remove set but not used variable
'idxd_cdev'
On 2/10/20 8:18 AM, YueHaibing wrote:
> drivers/dma/idxd/cdev.c: In function idxd_cdev_open:
> drivers/dma/idxd/cdev.c:77:20: warning:
> variable idxd_cdev set but not used [-Wunused-but-set-variable]
>
> commit 42d279f9137a ("dmaengine: idxd: add char driver to
> expose submission portal to userland") involed this.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
Acked-by: Dave Jiang <dave.jiang@...el.com>
> ---
> drivers/dma/idxd/cdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
> index 1d73478..8dfdbe3 100644
> --- a/drivers/dma/idxd/cdev.c
> +++ b/drivers/dma/idxd/cdev.c
> @@ -74,12 +74,10 @@ static int idxd_cdev_open(struct inode *inode, struct file *filp)
> struct idxd_device *idxd;
> struct idxd_wq *wq;
> struct device *dev;
> - struct idxd_cdev *idxd_cdev;
>
> wq = inode_wq(inode);
> idxd = wq->idxd;
> dev = &idxd->pdev->dev;
> - idxd_cdev = &wq->idxd_cdev;
>
> dev_dbg(dev, "%s called\n", __func__);
>
>
Powered by blists - more mailing lists