linux-kernel - Re: linux-5.6-rc1/tools/testing/selftests/bpf/prog_tests/select_reuseport.cc :826: possible cut-n-paste error ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200210170358.a46i2nklxfcf5t54@kafai-mbp.dhcp.thefacebook.com>
Date:   Mon, 10 Feb 2020 09:03:58 -0800
From:   Martin KaFai Lau <kafai@...com>
To:     David Binderman <dcb314@...mail.com>
CC:     "shuah@...nel.org" <shuah@...nel.org>,
        "ast@...nel.org" <ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "songliubraving@...com" <songliubraving@...com>,
        "yhs@...com" <yhs@...com>, "andriin@...com" <andriin@...com>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re:
 linux-5.6-rc1/tools/testing/selftests/bpf/prog_tests/select_reuseport.cc
 :826: possible cut-n-paste error ?

On Mon, Feb 10, 2020 at 01:42:45PM +0000, David Binderman wrote:
> Hello there,
> 
>     saved_tcp_fo = read_int_sysctl(TCP_FO_SYSCTL);
>     saved_tcp_syncookie = read_int_sysctl(TCP_SYNCOOKIE_SYSCTL);
>     if (saved_tcp_syncookie < 0 || saved_tcp_syncookie < 0)
>         goto out;
> 
> Maybe better code
> 
>     saved_tcp_fo = read_int_sysctl(TCP_FO_SYSCTL);
>     saved_tcp_syncookie = read_int_sysctl(TCP_SYNCOOKIE_SYSCTL);
>     if (saved_tcp_fo < 0 || saved_tcp_syncookie < 0)
Thanks for the report.  I will post a fix.