linux-kernel - Re: [PATCH v2] gpio: ich: fix a typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZbkJjyRPjgrA=i71tkWcD2nAxymMsXYVVrb=t_EsDSnA@mail.gmail.com>
Date:   Mon, 10 Feb 2020 13:06:59 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>,
        Jonathan Corbet <corbet@....net>
Cc:     sachin agarwal <asachin591@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        andy@...nel.org
Subject: Re: [PATCH v2] gpio: ich: fix a typo

On Mon, Feb 10, 2020 at 10:54 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> niedz., 9 lut 2020 o 12:16 sachin agarwal <asachin591@...il.com> napisał(a):
> >
> > From: sachin agarwal <asachin591@...il.com>
> >
> > We had written "Mangagment" rather than "Management".
> >
> > Signed-off-by: Sachin Agarwal <asachin591@...il.com>
> > ---
> >  drivers/gpio/gpio-ich.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c
> > index 2f086d0aa1f4..9960bb8b0f5b 100644
> > --- a/drivers/gpio/gpio-ich.c
> > +++ b/drivers/gpio/gpio-ich.c
> > @@ -89,7 +89,7 @@ static struct {
> >         struct device *dev;
> >         struct gpio_chip chip;
> >         struct resource *gpio_base;     /* GPIO IO base */
> > -       struct resource *pm_base;       /* Power Mangagment IO base */
> > +       struct resource *pm_base;       /* Power Management IO base */
> >         struct ichx_desc *desc; /* Pointer to chipset-specific description */
> >         u32 orig_gpio_ctrl;     /* Orig CTRL value, used to restore on exit */
> >         u8 use_gpio;            /* Which GPIO groups are usable */
> > --
> > 2.24.1
> >
>
> I'm seeing that you have been sending a lot of these single typo
> fixes. This is polluting the history and I'm not a fan of that.
>
> Linus: what is your policy on this?

I don't really have one, I think it's usually nice to do as a drive-by
change when fixing something else. I like what is said about
fixing whitespace and codingstyle issues in the document
Documentation/process/2.Process.rst heading
"Getting started with Kernel development":

  Individual developers are often, understandably, at a loss for a place to
  start.  Beginning with a large project can be intimidating; one often wants
  to test the waters with something smaller first.  This is the point where
  some developers jump into the creation of patches fixing spelling errors or
  minor coding style issues.  Unfortunately, such patches create a level of
  noise which is distracting for the development community as a whole, so,
  increasingly, they are looked down upon.  New developers wishing to
  introduce themselves to the community will not get the sort of reception
  they wish for by these means.

(Jonathan Corbet)

I recommend newcomers to read the whole document, or their
contributions might get increasingly ignored.

Yours,
Linus Walleij