linux-kernel - Re: [PATCH] gpio/sifive: fix static checker warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY2Zahr0mLUp+dBOzZbthsttLS=oKitPJVS_xQh8RwZqA@mail.gmail.com>
Date:   Mon, 10 Feb 2020 13:55:10 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Yash Shah <yash.shah@...ive.com>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        "Wesley W. Terpstra" <wesley@...ive.com>,
        Marc Zyngier <maz@...nel.org>,
        Atish Patra <atish.patra@....com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        linux-riscv@...ts.infradead.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sachin Ghadi <sachin.ghadi@...ive.com>
Subject: Re: [PATCH] gpio/sifive: fix static checker warning

On Tue, Jan 28, 2020 at 6:24 AM Yash Shah <yash.shah@...ive.com> wrote:

> Typcasting "irq_state" leads to the below static checker warning:
> The fix is to declare "irq_state" as unsigned long instead of u32.
>
>         drivers/gpio/gpio-sifive.c:97 sifive_gpio_irq_enable()
>         warn: passing casted pointer '&chip->irq_state' to
>         'assign_bit()' 32 vs 64.
>
> Fixes: 96868dce644d ("gpio/sifive: Add GPIO driver for SiFive SoCs")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Yash Shah <yash.shah@...ive.com>

Patch applied for GPIO fixes.

Yours,
Linus Walleij