linux-kernel - Re: [PATCH] ALSA: usb-audio: Apply sample rate quirk for Audioengine D1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hlfp90wcf.wl-tiwai@suse.de>
Date:   Tue, 11 Feb 2020 20:15:12 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Arvind Sankar <nivedita@...m.mit.edu>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        <alsa-devel@...a-project.org>, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: Apply sample rate quirk for Audioengine D1

On Tue, 11 Feb 2020 17:22:35 +0100,
Arvind Sankar wrote:
> 
> The Audioengine D1 (0x2912:0x30c8) does support reading the sample rate,
> but it returns the rate in byte-reversed order.
> 
> When setting sampling rate, the driver produces these warning messages:
> [168840.944226] usb 3-2.2: current rate 4500480 is different from the runtime rate 44100
> [168854.930414] usb 3-2.2: current rate 8436480 is different from the runtime rate 48000
> [168905.185825] usb 3-2.1.2: current rate 30465 is different from the runtime rate 96000
> 
> As can be seen from the hexadecimal conversion, the current rate read
> back is byte-reversed from the rate that was set.
> 
> 44100 == 0x00ac44, 4500480 == 0x44ac00
> 48000 == 0x00bb80, 8436480 == 0x80bb00
> 96000 == 0x017700,   30465 == 0x007701
> 
> Rather than implementing a new quirk to reverse the order, just skip
> checking the rate to avoid spamming the log.
> 
> Signed-off-by: Arvind Sankar <nivedita@...m.mit.edu>

Thanks, applied now with Cc to stable.


Takashi