lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Feb 2020 23:45:36 +0000 From: Russell King - ARM Linux admin <linux@...linux.org.uk> To: Li Yang <leoyang.li@....com> Cc: Joerg Roedel <joro@...tes.org>, Will Deacon <will.deacon@....com>, Robin Murphy <robin.murphy@....com>, iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH] iommu/arm-smmu: fix the module name for disable_bypass parameter On Tue, Feb 11, 2020 at 05:36:55PM -0600, Li Yang wrote: > Since commit cd221bd24ff5 ("iommu/arm-smmu: Allow building as a module"), > there is a side effect that the module name is changed from arm-smmu to > arm-smmu-mod. So the kernel parameter for disable_bypass need to be > changed too. Fix the Kconfig help and error message to the correct > parameter name. Hmm, this seems to be a user-visible change - so those of us who have been booting with "arm-smmu.disable_bypass=0" now need to change that depending on which kernel is being booted - which is not nice, and makes the support side on platforms that need this kernel parameter harder. > > Signed-off-by: Li Yang <leoyang.li@....com> > --- > drivers/iommu/Kconfig | 2 +- > drivers/iommu/arm-smmu.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > index d2fade984999..fb54be903c60 100644 > --- a/drivers/iommu/Kconfig > +++ b/drivers/iommu/Kconfig > @@ -415,7 +415,7 @@ config ARM_SMMU_DISABLE_BYPASS_BY_DEFAULT > hardcode the bypass disable in the code. > > NOTE: the kernel command line parameter > - 'arm-smmu.disable_bypass' will continue to override this > + 'arm-smmu-mod.disable_bypass' will continue to override this > config. > > config ARM_SMMU_V3 > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 16c4b87af42b..2ffe8ff04393 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -512,7 +512,7 @@ static irqreturn_t arm_smmu_global_fault(int irq, void *dev) > if (IS_ENABLED(CONFIG_ARM_SMMU_DISABLE_BYPASS_BY_DEFAULT) && > (gfsr & ARM_SMMU_sGFSR_USF)) > dev_err(smmu->dev, > - "Blocked unknown Stream ID 0x%hx; boot with \"arm-smmu.disable_bypass=0\" to allow, but this may have security implications\n", > + "Blocked unknown Stream ID 0x%hx; boot with \"arm-smmu-mod.disable_bypass=0\" to allow, but this may have security implications\n", > (u16)gfsynr1); > else > dev_err(smmu->dev, > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@...ts.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
Powered by blists - more mailing lists