[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200211054433.GB72419@google.com>
Date: Tue, 11 Feb 2020 05:44:33 +0000
From: Quentin Perret <qperret@...gle.com>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Nicolas Pitre <nico@...xnic.net>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
Matthias Maennich <maennich@...gle.com>,
"Cc: Android Kernel" <kernel-team@...roid.com>,
Jessica Yu <jeyu@...nel.org>,
Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH v3 1/3] kbuild: allow symbol whitelisting with
TRIM_UNUSED_KSYMS
On Saturday 08 Feb 2020 at 06:05:02 (+0100), Masahiro Yamada wrote:
> On Fri, Feb 7, 2020 at 7:08 PM Quentin Perret <qperret@...gle.com> wrote:
> > diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh
> > index a904bf1f5e67..58335eee4b38 100755
> > --- a/scripts/adjust_autoksyms.sh
> > +++ b/scripts/adjust_autoksyms.sh
> > @@ -38,6 +38,10 @@ esac
> > # We need access to CONFIG_ symbols
> > . include/config/auto.conf
> >
> > +# The symbol whitelist, relative to the source tree
> > +eval ksym_wl="${CONFIG_UNUSED_KSYMS_WHITELIST:-/dev/null}"
>
> What is this 'eval' needed for?
>
> This worked for me without it.
Right, it is there to expand the path in cases where the user sets the
option to "~/my_whitelist" for instance. That could most certainly use a
comment, though.
Thanks,
Quentin
Powered by blists - more mailing lists