linux-kernel - Re: [PATCH] iommu/vt-d: Fix compile warning from intel-svm.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <723094c4-1c4c-7d52-d737-d0f201e634d6@linux.intel.com>
Date:   Tue, 11 Feb 2020 08:24:24 +0800
From:   Lu Baolu <baolu.lu@...ux.intel.com>
To:     Joerg Roedel <joro@...tes.org>, iommu@...ts.linux-foundation.org
Cc:     David Woodhouse <dwmw2@...radead.org>,
        Joerg Roedel <jroedel@...e.de>, CQ Tang <cq.tang@...el.com>,
        Ashok Raj <ashok.raj@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/vt-d: Fix compile warning from intel-svm.h

Hi Joerg,

On 2020/2/10 17:36, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@...e.de>
> 
> The intel_svm_is_pasid_valid() needs to be marked inline, otherwise it
> causes the compile warning below:
> 
>    CC [M]  drivers/dma/idxd/cdev.o
> In file included from drivers/dma/idxd/cdev.c:9:0:
> ./include/linux/intel-svm.h:125:12: warning: ‘intel_svm_is_pasid_valid’ defined but not used [-Wunused-function]
>   static int intel_svm_is_pasid_valid(struct device *dev, int pasid)
>              ^~~~~~~~~~~~~~~~~~~~~~~~
> 
> Reported-by: Borislav Petkov <bp@...en8.de>
> Fixes: 15060aba71711 ('iommu/vt-d: Helper function to query if a pasid has any active users')
> Signed-off-by: Joerg Roedel <jroedel@...e.de>

Acked-by: Lu Baolu <baolu.lu@...ux.intel.com>

Best regards,
baolu

> ---
>   include/linux/intel-svm.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/intel-svm.h b/include/linux/intel-svm.h
> index 94f047a8a845..d7c403d0dd27 100644
> --- a/include/linux/intel-svm.h
> +++ b/include/linux/intel-svm.h
> @@ -122,7 +122,7 @@ static inline int intel_svm_unbind_mm(struct device *dev, int pasid)
>   	BUG();
>   }
>   
> -static int intel_svm_is_pasid_valid(struct device *dev, int pasid)
> +static inline int intel_svm_is_pasid_valid(struct device *dev, int pasid)
>   {
>   	return -EINVAL;
>   }
>