linux-kernel - Re: [PATCH] usb: xhci: Enable LPM for VIA LABS VL805

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1478f170-f0ec-96df-79cf-f7c44bebc290@linux.intel.com>
Date:   Tue, 11 Feb 2020 11:34:59 +0200
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Mathias Nyman <mathias.nyman@...el.com>
Cc:     linux-rpi-kernel@...ts.infradead.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: xhci: Enable LPM for VIA LABS VL805

On 10.2.2020 20.59, Greg Kroah-Hartman wrote:
> On Mon, Jan 20, 2020 at 03:24:22PM +0100, Nicolas Saenz Julienne wrote:
>> This PCIe controller chip is used on the Raspberry Pi 4 and multiple
>> adapter cards. There is no publicly available documentation for the
>> chip, yet both the downstream RPi4 kernel and the controller cards
>> support/advertise LPM support.
>>
>> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
>> ---
>>  drivers/usb/host/xhci-pci.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
>> index 4917c5b033fa..c1976e98992b 100644
>> --- a/drivers/usb/host/xhci-pci.c
>> +++ b/drivers/usb/host/xhci-pci.c
>> @@ -241,6 +241,9 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>>  			pdev->device == 0x3432)
>>  		xhci->quirks |= XHCI_BROKEN_STREAMS;
>>  
>> +	if (pdev->vendor == PCI_VENDOR_ID_VIA && pdev->device == 0x3483)
>> +		xhci->quirks |= XHCI_LPM_SUPPORT;
>> +
>>  	if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&
>>  			pdev->device == 0x1042)
>>  		xhci->quirks |= XHCI_BROKEN_STREAMS;
> 
> Mathias, is this in your review queue?
> 

Ah yes, before adding link power management support for this controller we
should check that it has sane (or any) exit latency values set in its
HCSPARAMS3 capability register.

Nicolas, if you have this controller could you show the capability registers:

cat /sys/kernel/debug/usb/xhci/*/reg-cap

-Mathias