linux-kernel - Re: [PATCH] platform/chrome: wilco_ec: Include asm/unaligned instead of linux/ path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4bdff9a-4cd9-70a2-7625-accc6146e063@collabora.com>
Date:   Tue, 11 Feb 2020 10:40:11 +0100
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Stephen Boyd <swboyd@...omium.org>,
        Benson Leung <bleung@...omium.org>
Cc:     linux-kernel@...r.kernel.org, Nick Crews <ncrews@...omium.org>,
        kbuild test robot <lkp@...el.com>
Subject: Re: [PATCH] platform/chrome: wilco_ec: Include asm/unaligned instead
 of linux/ path

Hi Stephen,

On 3/2/20 18:46, Stephen Boyd wrote:
> It seems that we shouldn't try to include the include/linux/ path to
> unaligned functions. Just include asm/unaligned.h instead so that we
> don't run into compilation warnings like below.
> 
>    In file included from drivers/platform/chrome/wilco_ec/properties.c:8:0:
>    include/linux/unaligned/le_memmove.h:7:19: error: redefinition of 'get_unaligned_le16'
>     static inline u16 get_unaligned_le16(const void *p)
>                       ^~~~~~~~~~~~~~~~~~
>    In file included from arch/ia64/include/asm/unaligned.h:5:0,
>                     from arch/ia64/include/asm/io.h:23,
>                     from arch/ia64/include/asm/smp.h:21,
>                     from include/linux/smp.h:68,
>                     from include/linux/percpu.h:7,
>                     from include/linux/arch_topology.h:9,
>                     from include/linux/topology.h:30,
>                     from include/linux/gfp.h:9,
>                     from include/linux/xarray.h:14,
>                     from include/linux/radix-tree.h:18,
>                     from include/linux/idr.h:15,
>                     from include/linux/kernfs.h:13,
>                     from include/linux/sysfs.h:16,
>                     from include/linux/kobject.h:20,
>                     from include/linux/device.h:16,
>                     from include/linux/platform_data/wilco-ec.h:11,
>                     from drivers/platform/chrome/wilco_ec/properties.c:6:
>    include/linux/unaligned/le_struct.h:7:19: note: previous definition of 'get_unaligned_le16' was here
>     static inline u16 get_unaligned_le16(const void *p)
>                       ^~~~~~~~~~~~~~~~~~
> Reported-by: kbuild test robot <lkp@...el.com>
> Fixes: 60fb8a8e93ca ("platform/chrome: wilco_ec: Allow wilco to be compiled in COMPILE_TEST")
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---

Queued as a fix for 5.6. Thanks,

  Enric