linux-kernel - Re: [PATCH v5 8/9] crypto: caam - add crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB34854BA34A65EE7131F3831198180@VI1PR0402MB3485.eurprd04.prod.outlook.com>
Date:   Tue, 11 Feb 2020 10:23:16 +0000
From:   Horia Geanta <horia.geanta@....com>
To:     Iuliana Prodan <iuliana.prodan@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@....com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Silvano Di Ninno <silvano.dininno@....com>,
        Franck Lenormand <franck.lenormand@....com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH v5 8/9] crypto: caam - add crypto_engine support for RSA
 algorithms

On 1/30/2020 2:49 AM, Iuliana Prodan wrote:
> @@ -1029,6 +1107,10 @@ static int caam_rsa_init_tfm(struct crypto_akcipher *tfm)
>  		return -ENOMEM;
>  	}
>  
> +	ctx->enginectx.op.do_one_request = akcipher_do_one_req;
> +
> +	akcipher_set_reqsize(tfm, sizeof(struct caam_rsa_req_ctx));
This is redundant with the static initialization of caam_rsa:
	.reqsize = sizeof(struct caam_rsa_req_ctx),

Horia