linux-kernel - Re: [[PATCH staging] 7/7] staging: wfx: use more power-efficient sleep for reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2074006.CDZ1VyBi8C@pc-42>
Date:   Tue, 11 Feb 2020 10:45:44 +0000
From:   Jérôme Pouiller <Jerome.Pouiller@...abs.com>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [[PATCH staging] 7/7] staging: wfx: use more power-efficient
 sleep for reset

On Tuesday 11 February 2020 09:46:56 CET Michał Mirosław wrote:
>
> Replace udelay() with usleep_range() as all uses are in a sleepable context.
> 
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> ---
>  drivers/staging/wfx/bh.c      | 2 +-
>  drivers/staging/wfx/bus_spi.c | 4 ++--
>  drivers/staging/wfx/hwio.c    | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c
> index c6319ab7e71a..9fcab00a3733 100644
> --- a/drivers/staging/wfx/bh.c
> +++ b/drivers/staging/wfx/bh.c
> @@ -26,7 +26,7 @@ static void device_wakeup(struct wfx_dev *wdev)
>         gpiod_set_value_cansleep(wdev->pdata.gpio_wakeup, 1);
>         if (wfx_api_older_than(wdev, 1, 4)) {
>                 if (!completion_done(&wdev->hif.ctrl_ready))
> -                       udelay(2000);
> +                       usleep_range(2000, 2500);
>         } else {
>                 // completion.h does not provide any function to wait
>                 // completion without consume it (a kind of
> diff --git a/drivers/staging/wfx/bus_spi.c b/drivers/staging/wfx/bus_spi.c
> index 634b4e5bb055..14729af2c405 100644
> --- a/drivers/staging/wfx/bus_spi.c
> +++ b/drivers/staging/wfx/bus_spi.c
> @@ -209,9 +209,9 @@ static int wfx_spi_probe(struct spi_device *func)
>                 if (spi_get_device_id(func)->driver_data & WFX_RESET_INVERTED)
>                         gpiod_toggle_active_low(bus->gpio_reset);
>                 gpiod_set_value_cansleep(bus->gpio_reset, 1);
> -               udelay(100);
> +               usleep_range(100, 150);
>                 gpiod_set_value_cansleep(bus->gpio_reset, 0);
> -               udelay(2000);
> +               usleep_range(2000, 2500);
>         }
> 
>         INIT_WORK(&bus->request_rx, wfx_spi_request_rx);
> diff --git a/drivers/staging/wfx/hwio.c b/drivers/staging/wfx/hwio.c
> index 47e04c59ed93..d3a141d95a0e 100644
> --- a/drivers/staging/wfx/hwio.c
> +++ b/drivers/staging/wfx/hwio.c
> @@ -142,7 +142,7 @@ static int indirect_read(struct wfx_dev *wdev, int reg, u32 addr, void *buf,
>                         goto err;
>                 if (!(cfg & prefetch))
>                         break;
> -               udelay(200);
> +               usleep_range(200, 250);
>         }
>         if (i == 20) {
>                 ret = -ETIMEDOUT;
> --
> 2.20.1
> 

Reviewed-by: Jérôme Pouiller <jerome.pouiller@...abs.com>

-- 
Jérôme Pouiller