linux-kernel - [PATCH] mm: Add missed mem_cgroup_iter_break() into shrink_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <158142103093.888182.8911729633457501747.stgit@localhost.localdomain>
Date:   Tue, 11 Feb 2020 14:38:57 +0300
From:   Kirill Tkhai <ktkhai@...tuozzo.com>
To:     akpm@...ux-foundation.org, guro@...com, vvs@...tuozzo.com,
        ktkhai@...tuozzo.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] mm: Add missed mem_cgroup_iter_break() into
 shrink_node_memcgs()

Leaving mem_cgroup_iter() loop requires mem_cgroup_iter_break().

Fixes: bf8d5d52ffe8 "memcg: introduce memory.min"
Signed-off-by: Kirill Tkhai <ktkhai@...tuozzo.com>
---
 mm/vmscan.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index b1863de475fb..f6efe2348ba3 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2653,8 +2653,9 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc)
 				continue;
 			}
 			memcg_memory_event(memcg, MEMCG_LOW);
-			break;
+			/* fallthrough */
 		case MEMCG_PROT_NONE:
+			mem_cgroup_iter_break(target_memcg, memcg);
 			/*
 			 * All protection thresholds breached. We may
 			 * still choose to vary the scan pressure